Make configuration validation function return validation error message #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spbnick
requested changes
Mar 27, 2018
lib/tlog/play_conf.c
Outdated
| /* Check validate the config */ | ||
| assert(tlog_play_conf_validate(NULL, | ||
| conf, | ||
| TLOG_CONF_ORIGIN_ARGS) == TLOG_RC_OK); |
There was a problem hiding this comment.
Could you wrap it a bit differently, so it takes less lines? Here and elsewhere? E.g.:
assert(tlog_play_conf_validate(NULL, conf, TLOG_CONF_ORIGIN_ARGS) ==
TLOG_RC_OK);
|
I have updated it |
spbnick
requested changes
Mar 28, 2018
| @@ -75,6 +75,9 @@ tlog_play_conf_load(struct tlog_errs **perrs, | |||
| assert(pcmd_help != NULL); | |||
| assert(pconf != NULL); | |||
| assert(argv != NULL); | |||
| /* Check validate the config */ | |||
| assert(tlog_play_conf_validate(NULL, conf, TLOG_CONF_ORIGIN_ARGS) == | |||
| TLOG_RC_OK); | |||
There was a problem hiding this comment.
This wouldn't make sense, we don't need to validate a NULL pointer we just initialized. This function doesn't need to validate the configuration it receives, as it doesn't receive any. The same for the rest of those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Nick, PR for issue #41 to make configuration validation function return validation error message by using
assert.